refactor(modules): return has update for unexpected module fw filename #14712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14712 +/- ##
=======================================
Coverage 67.20% 67.20%
=======================================
Files 2495 2495
Lines 71595 71593 -2
Branches 9076 9076
=======================================
- Hits 48114 48113 -1
+ Misses 21336 21335 -1
Partials 2145 2145
Flags with carried forward coverage won't be shown. Click here to find out more.
|
SyntaxColoring
changed the title
SyntaxColoring
approved these changes
Mar 21, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When we flash local firmware changes to a module using an ST-Link, the file produced will have the usual firmware filename for the module, except with a commit hash amended in the middle of it.
Currently, having the filename altered like this causes the robot server not to recognize that a module is present at all. Instead, this change allows the app to reflect that the module is there and offer an available update.
Changelog
InvalidVersionerror for both current and available device versions